-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show github actions build number in startup log and version check command #4336
Open
onebeastchris
wants to merge
15
commits into
GeyserMC:master
Choose a base branch
from
onebeastchris:build-number
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't check build number if running a dev build Show dev build warning in console
onebeastchris
added
PR: Feature
When a PR implements a new feature
PR: Cosmetic
When a PR adds something that is purely cosmetic, like changing the README
labels
Dec 13, 2023
Konicai
reviewed
Dec 13, 2023
onebeastchris
added
the
PR: Needs review
Indicates that a PR is functional and review-ready.
label
Dec 16, 2023
Kas-tle
approved these changes
Dec 19, 2023
Camotoy
reviewed
Dec 19, 2023
Camotoy
reviewed
Dec 19, 2023
Camotoy
reviewed
Dec 19, 2023
Tim203
requested changes
Dec 31, 2023
Changed GeyserImpl.VERSION to consist of build number (e.g 420) + git info instead of geyser version (2.2.0-SNAPSHOT) + git info
Co-authored-by: Tim203 <mctim203@gmail.com>
…dev to reflect build version - make isDev a variable in the GitInfo class
Camotoy
approved these changes
Jan 22, 2024
Tim203
approved these changes
Jan 22, 2024
onebeastchris
added
PR: On hold
When a PR is on hold like if it requires a dependency to be updated first
and removed
PR: Needs review
Indicates that a PR is functional and review-ready.
labels
Jan 22, 2024
Must be adapted as build number is no longer pulled directly from GH actions and instead uses the env variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: Cosmetic
When a PR adds something that is purely cosmetic, like changing the README
PR: Feature
When a PR implements a new feature
PR: On hold
When a PR is on hold like if it requires a dependency to be updated first
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
TODO's:
Would fix #1748