-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emulate client side vehicle movement #4648
base: dev
Are you sure you want to change the base?
Conversation
core/src/main/java/org/geysermc/geyser/entity/vehicle/VehicleComponent.java
Outdated
Show resolved
Hide resolved
|
||
Vector2f getAdjustedInput(Vector2f input); | ||
|
||
boolean isLogicalSideForUpdatingMovement(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a method name pulled from NMS, but I'm not a huge fan of the naming. The name doesn't line up very well with what the method actually checks for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe isClientControlled()
(or similar)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree the name isn't great. Chris' suggestion sounds good to me so I used that for now
This PR adds support for vehicles that are controlled by the client (Camel, Strider, Pig).
Movement should be extremely close to a real java client, and many situations are accurately handled such as fluid, slime and honey blocks, climbing, etc.
Todo