✨ [Feature] Add status to get friends #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jis-kim
requested review from
anso33 and
Kimhan-nah
and removed request for
anso33
jis-kim
commented
May 9, 2023
| // messgeView 가 없으면 (find() 가 undefined 이면) null | ||
| const lastViewTime = messageView.find((view) => view.user.id === userId)?.lastViewTime || null; | ||
| const friend = sender.id === userId ? receiver : sender; | ||
| const status = this.userStatusRepository.find(friend.id)?.status || 'offline'; |
There was a problem hiding this comment.
위에서 찾은 friend의 id 로 userStatusRepository 의 key 가 있는 지 체크해서 있으면 status, 없으면 offline 을 보냅니다.
Kimhan-nah
reviewed
May 9, 2023
| @@ -9,7 +9,7 @@ import { Repository } from './repository.interface'; | |||
| */ | |||
| @Injectable() | |||
| export class UserStatusRepository implements Repository<number, UserStatus> { | |||
| private readonly userStatusList: Map<number, UserStatus>; | |||
| private readonly userStatusList: Map<number, UserStatus> = new Map<number, UserStatus>(); | |||
There was a problem hiding this comment.
생각해보니까 아래에서 userStatusList에 대해 set과 같이 update가 필요한데 readonly가 있어도 괜찮나요??
There was a problem hiding this comment.
userStatusList 라는 Map 객체에 대한 readonly 라서 element 를 수정하는 것에는 지장이 없습니다!
| // messgeView 가 없으면 (find() 가 undefined 이면) null | ||
| const lastViewTime = messageView.find((view) => view.user.id === userId)?.lastViewTime || null; | ||
| const friend = sender.id === userId ? receiver : sender; | ||
| const status = this.userStatusRepository.find(friend.id)?.status || 'offline'; |
There was a problem hiding this comment.
윗 댓글에 어떤 상황에서 offline 이 되는 지 적어놓았습니다. 참고해주세요!
위에서 찾은
friend의id로userStatusRepository의key가 있는 지 체크해서 있으면status, 없으면offline을 보냅니다.
anso33
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GET /friendAPI 수정Describe your changes
RepositoryModule을AppModule에 등록 및FriendModule에서 import 하여 사용합니다.ts-node로 컴파일하면 패키지 로딩 때require가 사용되는데,nanoid@4.0.0부터는import만 허용되고require는 허용하지 않는 이슈가 있어3.3.4로 버전을 다운그레이드 하였습니다. 참고Issue number and link