-
Notifications
You must be signed in to change notification settings - Fork 653
Add HEAD support #3241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HEAD support #3241
Conversation
PR submitted, all tests pass. @asbjornu any suggestions for improvement? |
@@ -552,6 +552,11 @@ Example of invalid `Strict`, but valid `Loose` | |||
1.2.3.4 | |||
``` | |||
### handle-detached-branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're targeting main
, this is going to be rolled into v6. To target v5, you need to rebase and retarget against support/5.x
, but I would like to avoid the introduction of new configuration properties. As such, I don't think we need any new configuration properties to add support for detached HEAD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it's ok to go for v6. Are you proposing to change the beaviour and always handle detached branches? Will I remove the handle-detached-branch
option and every changes correlated?
src/GitVersion.Core.Tests/IntegrationTests/RemoteRepositoryScenarios.cs
Outdated
Show resolved
Hide resolved
* RepositoryStore.cs
Superseded by #3338. |
🎉 This issue has been resolved in version 5.12.0 🎉 Your GitReleaseManager bot 📦🚀 |
Description
Add support for detached branches through configuration option
handle-detached-branch
.Related Issue
Motivation and Context
Detached branches are common with submodules and development scenario. With this option enabled, you can build a project with detached branches without errors.
How Has This Been Tested?
GivenARemoteGitRepositoryWhenCheckingOutDetachedHeadUsingExistingImplementationHandleDetachedBranch
. I don't know if it's enough, I appreciate suggestions on how to add tests for this purpose.Checklist:
It looks like my code follows the code style, but please double check (also for documentation).