Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reo.Dev Integration #298

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add Reo.Dev Integration #298

wants to merge 8 commits into from

Conversation

vibhanshub
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 16, 2023

⚠️ No Changeset found

Latest commit: 14f3e89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@addisonschultz addisonschultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

One request - would you mind updating the folder name from reo.dev to reo? To avoid having . in the folder name—Additionally the service is just called "Reo"

Code is looking good, we'll just wait to see where the 403 error is coming from before merging this in.

@vibhanshub vibhanshub dismissed addisonschultz’s stale review November 17, 2023 17:20

Implemented the requested changes

@addisonschultz
Copy link
Contributor

Hi @vibhanshub - I've had to update the configuration and manifest based on some updates coming to sites. The context is mentioned in this PR (https://github.com/GitbookIO/integrations/pull/453/files)

This should be all that is needed, but can you review my last commit, and re-publish this integration if everything looks okay? We can keep the PR open, but just need to update the published version.

Let me know if you have any questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants