Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send segment events in queue #215

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

mohammadranjbarz
Copy link
Collaborator

related to #152

Copy link
Collaborator

@CarlosQ96 CarlosQ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

However I could reproduce the same issue where only 9/10 events were sent.
Seems they are working on the solution segmentio/analytics-node#309, maybe it's this issue they will solve soon. (Some form of race condition when the library flushes messages)

Another thing we can try last is the async track implementation. to kind of force the promise to be solve, I tried this and got the same issue tho: segmentio/analytics-node#303

I think we should proceed and wait for them to fix it. Unless you want to try something else.

@mohammadranjbarz
Copy link
Collaborator Author

Everything looks good to me.

However I could reproduce the same issue where only 9/10 events were sent. Seems they are working on the solution segmentio/analytics-node#309, maybe it's this issue they will solve soon. (Some form of race condition when the library flushes messages)

Another thing we can try last is the async track implementation. to kind of force the promise to be solve, I tried this and got the same issue tho: segmentio/analytics-node#303

I think we should proceed and wait for them to fix it. Unless you want to try something else.

Thanks Carlos, I agree, we can merge it as temporary solution, till Segment library will be fixed

@mohammadranjbarz mohammadranjbarz merged commit c54d21a into staging Nov 29, 2021
@CarlosQ96
Copy link
Collaborator

@aminlatifi This is the analytics-node library that presents issues. We did a big workaround with queues and delays for it to be as stable as posible.

@aminlatifi aminlatifi deleted the refactor_send_segment_Events branch January 25, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants