-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F 703 support multi recipient #531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore this hahah
@MoeNick @CarlosQ96 @MohammadPCh After merging this PR ( we are waiting for current release after that we would review and merge this) createProject and updateProjectInstead of sending
Getting projectsIn every service that frontend gets project list or project detail , it would get address infoes as well with adding this to graphql query
And then based on each network that user selected on metamask frontend should use the address of that network, and make sure that the |
@CarlosQ96 Please review it, but I keep it draft to not merge it until the frontend guys @MohammadPCh or @MoeNick tell us to merge it, because this PR changes are not backward compatible and staging may break if we merge it without implementing frontend side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#525 (comment) I think you mentioned the projectByAddress mutation is no longer used. We should delete it as it would be incomplete with this Pr, it would need to search by related addresses too.
Same for project query. As we do not user repository to fetch project.
if (purpleAddress) return true; | ||
|
||
return false; | ||
return isWalletAddressInPurpleList(address); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sql injection can be done here, escape the address on the raw query.
Quick question, is the previous purple address list lost? gotta reintroduce them in the adminbro? |
Yeah we would lose them, but now there isn't any purple addresses in our DB and I told Ashley to not add any addresses until we merge this, so it would not make a problem |
I think we can skip deleting the other mutations for now. The sql injection is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job man! All issues fixed. I think we only have to coordinate with @mateodaza to merge. He is wanting to integrate.
related to Giveth/giveth-dapps-v2#703