Draft: Add GooPdf with statistical background subtraction #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds
GooPdfBkgSub
, which is aGooPdf
along with anUnbinnedDataSet
that can be used for subtracting the background contribution to the likelihood. TheUnbinnedDataSet
can be used to describe any background contribution that can't be parameterized and incorporated into the underlyingGooPdf
. Note that this implementation is only valid for un-extended, unbinned NLL fits.This is based on the method used in AmpTools described here: https://github.com/mashephe/AmpTools/blob/master/AmpTools_User_Guide.pdf.
FYI @cpappenheimer @FlorianReiss @JuanBSLeite
TODO:
GooPdf
and fit data for validity (un-extended fit, unbinned fit data)Optional add-ons: