Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add GooPdf with statistical background subtraction #367

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

thboettc
Copy link
Collaborator

@thboettc thboettc commented May 7, 2023

This MR adds GooPdfBkgSub, which is a GooPdf along with an UnbinnedDataSet that can be used for subtracting the background contribution to the likelihood. The UnbinnedDataSet can be used to describe any background contribution that can't be parameterized and incorporated into the underlying GooPdf. Note that this implementation is only valid for un-extended, unbinned NLL fits.

This is based on the method used in AmpTools described here: https://github.com/mashephe/AmpTools/blob/master/AmpTools_User_Guide.pdf.

FYI @cpappenheimer @FlorianReiss @JuanBSLeite

TODO:

  • Add an example for testing
  • Add python binding
  • Check underlying GooPdf and fit data for validity (un-extended fit, unbinned fit data)

Optional add-ons:

  • Add support for extended fits
  • Add data generation method (could be accomplished by resampling background events)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant