Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lighthouse smoketests (windows, lantern) to CI #265

Merged
merged 24 commits into from
May 31, 2022
Merged

Conversation

paulirish
Copy link
Member

per GoogleChrome/lighthouse#14023 and GoogleChrome/lighthouse#13871 we've been having some challenges with the windows smoke tests

and generally the problem is the taskkill command to close the browser.

I've been doing some work on this but first thing that makes sense is to add the LH smoketests (just windows) to the chrome-launcher CI.

typically its the lantern smoketests that trigger the failure, so i'm running just those.

package.json Outdated Show resolved Hide resolved
@paulirish
Copy link
Member Author

I'm happy with these. I'm reliably seeing the taskkill failures in the CI here. example run: https://github.com/GoogleChrome/chrome-launcher/runs/6662411663?check_suite_focus=true

The smokehouse retries often end up resolving it, so the CI often passes, but the above run was a case where lantern-online continued to fail despite 5 retries.

@paulirish paulirish merged commit 690ae98 into master May 31, 2022
@paulirish paulirish deleted the lighthouse-smoke branch May 31, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants