Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing edit icon on new features page for features I own #3569

Open
GabriellaMSanchez opened this issue Jan 4, 2024 · 6 comments
Open

Missing edit icon on new features page for features I own #3569

GabriellaMSanchez opened this issue Jan 4, 2024 · 6 comments
Labels
bug goodfirstbug

Comments

@GabriellaMSanchez
Copy link

Describe the bug
On the new features page, the edit icon is missing even though I am signed in and I own this feature. I am able to click into this feature and edit it on the feature detail page. This bug occurs whether I am logged into my personal email or the example@chromium.org email log in.

To Reproduce
Steps to reproduce the behavior:

  1. Be logged into your account or the example@chromium.org account.
  2. Click on "All Features" on the side bar.
  3. Click on "Try out our new features page".
  4. See error [screenshot below]
Screen Shot 2024-01-03 at 6 43 53 PM
@DanielRyanSmith
Copy link
Collaborator

DanielRyanSmith commented Jan 8, 2024 •
edited

I have confirmed that the edit icon does not display here for editable features of users without special site permissions. It seems that the permissions are being passed down to the table checking if the user is a site editor or admin that can edit every feature. That means that either the edit icon will display for all features to editor-level users, or not at all for normal users, even if that user has access to edit the feature.

@Ali7040
Copy link

Ali7040 commented Feb 22, 2024

Please assign it to me. I want to work on that.

@BalrajDhakad
Copy link

Hey,
This is Balraj,
I am new to open source and I want to contribute to this issue.
@DanielRyanSmith @GabriellaMSanchez can you please elaborate it to me

@DanielRyanSmith DanielRyanSmith mentioned this issue Feb 28, 2024
Closed
@Rishikesh63
Copy link

Screenshot_2024_0314_144419
I have not seen create feature and edit icon .can you please guide me

@r3yc0n1c
Copy link
Contributor

@DanielRyanSmith I have an idea to fix this. If this issue is still open, I would like to work on it.

@afeedhshaji afeedhshaji mentioned this issue Mar 23, 2024
Closed
@afeedhshaji
Copy link

I might have fixed this issue in #3734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug goodfirstbug
Projects
None yet
Milestone
No milestone
7 participants
@afeedhshaji @DanielRyanSmith @r3yc0n1c @Ali7040 @GabriellaMSanchez @Rishikesh63 @BalrajDhakad