Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing edit icon on new features page for user editable features #3734

Closed
wants to merge 1 commit into from

Conversation

afeedhshaji
Copy link

@afeedhshaji afeedhshaji commented Mar 23, 2024

Overview:

Added a new property to chromedash-feature-table that now takes in editableFeatures along with other existing props like starredFeatures etc. When rendering the rows for the table, this property will be used to decide if the user can edit the feature or not (along with the existing check if user has "all edit" permissions)

Fixes #3569

Copy link

google-cla bot commented Mar 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@DanielRyanSmith DanielRyanSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing these changes, features now selectively show which can be edited by the user on the new features page. Great job! Thanks for the fix.

@afeedhshaji
Copy link
Author

@DanielRyanSmith Can we merge this? (I see there are some merge conflicts. Happy to resolve it)

@jrobbins
Copy link
Collaborator

Let's not change the pencil icons right now. Our plan is to phase them out and remove the page that they link to. Users already have an "Edit fields" button to make edits.

@jrobbins jrobbins closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing edit icon on new features page for features I own
3 participants