Avoid getting permissions twice when signed out. #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlaliberte
reviewed
Mar 28, 2024
|
|
||
| // user is passed in from chromedash-app, but the user is not logged in | ||
| if (!this.user) { | ||
| if (this.user === null) { |
There was a problem hiding this comment.
Do you really mean "=== null". Where could the null value be coming from? Maybe add a comment about that.
dlaliberte
approved these changes
Mar 28, 2024
|
The playwright timeouts were due to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking into chromestatus performance I noticed that the permissions API call was being done twice on some page loads. It was only happening for signed-out users. I think the cause was just the way that these comparisons are done. This fix should make the site a bit faster for signed-out users, and also eliminate a potential distraction as I continue to work on performance for signed-in users.