Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin trial creation cron job #3861

Merged
merged 16 commits into from May 16, 2024
Merged

Conversation

DanielRyanSmith
Copy link
Collaborator

@DanielRyanSmith DanielRyanSmith commented May 8, 2024

This implements a new cron job that will send detect trial creation requests and send those creation requests to the to the origin trials API. This cron job will not be formally implemented until endpoint access has been landed on the origin trials API.

Changes by file:

  • cron.yaml: Add the cron definition, commented out until trial creation endpoints are available on the OT API.
  • framework/origin_trials_client.py: Add new functions to create an origin trial and activate an origin trial. Remove some code in the trial extension function to move to a utils function.
  • framework/utils.py: Add a new utility function to obtain chromium schedule date information.
  • internals/maintenance_scripts.py: Write a new cron job class that checks for any origin trial stages that are flagged for origin trial creation and process them. Additionally, activates those trials if needed, or sets an activation date if that trial should be activated in the future.
  • main.py: Add the route definition for trial creation cron job, commented out until trial creation endpoints are available on the OT API.

@DanielRyanSmith DanielRyanSmith marked this pull request as ready for review May 12, 2024 00:51
@DanielRyanSmith DanielRyanSmith changed the title Trial creation cron job Origin trial creation cron job May 12, 2024
internals/maintenance_scripts.py Outdated Show resolved Hide resolved
@DanielRyanSmith DanielRyanSmith merged commit ba64d25 into main May 16, 2024
7 checks passed
@DanielRyanSmith DanielRyanSmith deleted the 2024-05-06_ot-creation-cron branch May 16, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants