Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Cleanup of Workbox build examples #2222

Merged
merged 8 commits into from Mar 3, 2022
Merged

Cleanup of Workbox build examples #2222

merged 8 commits into from Mar 3, 2022

Conversation

jeffposnick
Copy link
Contributor

R: @malchata
CC: @tropicadri

This more of less matches the inline examples we added to the TSDocs in GoogleChrome/workbox#3038, and links to the relevant reference docs for the full configs in a way that's hopefully easier to find.

@netlify
Copy link

netlify bot commented Mar 3, 2022

✔️ Deploy Preview for developer-chrome-com ready!

🔨 Explore the source changes: dc613e8

🔍 Inspect the deploy log: https://app.netlify.com/sites/developer-chrome-com/deploys/6221236874fc180008a980be

😎 Browse the preview: https://deploy-preview-2222--developer-chrome-com.netlify.app

@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

site/en/docs/workbox/modules/workbox-build/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/workbox/modules/workbox-cli/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/workbox/modules/workbox-webpack-plugin/index.md

  • This file passed all of our automated Markdown audits.

1 similar comment
@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

site/en/docs/workbox/modules/workbox-build/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/workbox/modules/workbox-cli/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/workbox/modules/workbox-webpack-plugin/index.md

  • This file passed all of our automated Markdown audits.

Copy link
Member

@malchata malchata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typos, otherwise, LGTM!

@malchata malchata added content update workbox Issues related to workbox documentation. labels Mar 3, 2022
jeffposnick and others added 7 commits March 3, 2022 15:21
Co-authored-by: Jeremy Wagner <malchata@users.noreply.github.com>
Co-authored-by: Jeremy Wagner <malchata@users.noreply.github.com>
Co-authored-by: Jeremy Wagner <malchata@users.noreply.github.com>
Co-authored-by: Jeremy Wagner <malchata@users.noreply.github.com>
Co-authored-by: Jeremy Wagner <malchata@users.noreply.github.com>
Co-authored-by: Jeremy Wagner <malchata@users.noreply.github.com>
Co-authored-by: Jeremy Wagner <malchata@users.noreply.github.com>
@jeffposnick jeffposnick merged commit b71d5b6 into main Mar 3, 2022
@jeffposnick jeffposnick deleted the wb-build-examples branch March 3, 2022 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
content update workbox Issues related to workbox documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants