Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Add doc for Lighthouse bfcache audit #4873

Merged
merged 5 commits into from
Jan 20, 2023

Conversation

adamraine
Copy link
Member

Adds documentation for the new Lighthouse back/forward cache audit

GoogleChrome/lighthouse#14465

Drafting doc: 🔒 go/bf-cache-audit-docs

@netlify
Copy link

netlify bot commented Jan 12, 2023

Deploy Preview for developer-chrome-com ready!

Name Link
🔨 Latest commit 0a6ae9d
🔍 Latest deploy log https://app.netlify.com/sites/developer-chrome-com/deploys/63ca5be65e763d0008329644
😎 Deploy Preview https://deploy-preview-4873--developer-chrome-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@malchata malchata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Does this need to be redirected to from web.dev, or is this an entirely new audit?

@adamraine
Copy link
Member Author

Does this need to be redirected to from web.dev, or is this an entirely new audit?

It's an entirely new audit.

@malchata
Copy link
Member

SGTM! Merge when you're ready!

@adamraine
Copy link
Member Author

I don't have permission to merge, are you able to do it?

@malchata
Copy link
Member

malchata commented Jan 17, 2023

It looks like the Check / stage workflow is failing. I'm a bit hesitant to merge this if it's an important job that could break the site on deploy.

@devnook, are you aware of whether the workflow job mentioned above is crucial to merging? Does it fail often, or is this unusual?

@devnook devnook merged commit 901651a into GoogleChrome:main Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants