core(script-treemap-data): include unmapped bytes (#12452)

GoogleChrome · May 11, 2021 · ae57fac · ae57fac
1 parent 17e9a13
commit ae57fac
Show file tree

Hide file tree

Showing 5 changed files with 11,244 additions and 8,027 deletions.
diff --git a/lighthouse-core/audits/script-treemap-data.js b/lighthouse-core/audits/script-treemap-data.js
@@ -223,6 +223,17 @@ class ScriptTreemapDataAudit extends Audit {
           sourcesData[source] = sourceData;
         }
 
+        if (bundle.sizes.unmappedBytes) {
+          /** @type {SourceData} */
+          const sourceData = {
+            resourceBytes: bundle.sizes.unmappedBytes,
+          };
+          if (unusedJavascriptSummary.sourcesWastedBytes) {
+            sourceData.unusedBytes = unusedJavascriptSummary.sourcesWastedBytes['(unmapped)'];
+          }
+          sourcesData['(unmapped)'] = sourceData;
+        }
+
         node = this.makeScriptNode(scriptElement.src, bundle.rawMap.sourceRoot || '', sourcesData);
       } else {
         // No valid source map for this script, so we can only produce a single node.

diff --git a/lighthouse-core/computed/unused-javascript-summary.js b/lighthouse-core/computed/unused-javascript-summary.js
@@ -28,7 +28,7 @@ const makeComputedArtifact = require('./computed-artifact.js');
  * @property {number} totalBytes
  * @property {number} wastedBytes
  * @property {number=} wastedPercent
- * @property {Record<string, number>=} sourcesWastedBytes
+ * @property {Record<string, number>=} sourcesWastedBytes Keyed by file name. Includes (unmapped) key too.
  */
 
 class UnusedJavascriptSummary {