Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(errors-in-console): properly define default options #12200

Merged
merged 1 commit into from Mar 5, 2021

Conversation

brendankenny
Copy link
Member

@brendankenny brendankenny commented Mar 4, 2021

fixes #10198

#11901 did the real fix, but didn't notice that #9480 had defined the previously empty defaultOptions as a static method and not a getter.

Classic case of unit vs integration tests:

  • The upcoming work on overrides and getters/setters might catch this sort of thing in tsc in the future, but I'm not sure
  • One way we could tackle this is exposing a way of "properly" running an audit with all the setup and teardown that audit-runner does and using that for all unit tests instead of calling .audit() directly. That would take care of context being initialized correctly and it would do the AuditProduct -> AuditResult transformation so tests could run on the real audit output expected in the LHR.

@brendankenny brendankenny requested a review from a team as a code owner March 4, 2021 20:40
@brendankenny brendankenny requested review from connorjclark and removed request for a team March 4, 2021 20:40
@google-cla google-cla bot added the cla: yes label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PSI: "Browser errors were logged to console" due to Inspector-blocked resource
3 participants