Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(fr): update test artifact #12202

Merged
merged 1 commit into from
Mar 5, 2021
+4 −2
Merged

tests(fr): update test artifact #12202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions lighthouse-core/test/fraggle-rock/gather/navigation-runner-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,16 +133,18 @@ describe('NavigationRunner', () => {
{
...config,
navigations: [
{id: 'default', artifacts: ['Accessibility']},
{id: 'default', artifacts: ['FontSize']},
{id: 'second', artifacts: ['ConsoleMessages']},
],
},
{gatherMode: 'navigation'}
).config;

// Both gatherers will error in these test conditions, but artifact errors
// will be merged into single `artifacts` object.
const {artifacts} = await runner._navigations({driver, config, requestedUrl});
const artifactIds = Object.keys(artifacts);
expect(artifactIds).toContain('Accessibility');
expect(artifactIds).toContain('FontSize');
expect(artifactIds).toContain('ConsoleMessages');
});
});
Expand Down