Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(treemap): update colors on enter keypress #12496

Merged
merged 1 commit into from May 17, 2021
Merged

misc(treemap): update colors on enter keypress #12496

merged 1 commit into from May 17, 2021

Conversation

connorjclark
Copy link
Collaborator

ref #11254

@connorjclark connorjclark requested a review from a team as a code owner May 17, 2021 22:34
@connorjclark connorjclark requested review from patrickhulce and removed request for a team May 17, 2021 22:34
@google-cla google-cla bot added the cla: yes label May 17, 2021
@connorjclark connorjclark mentioned this pull request May 17, 2021
Closed
24 tasks
patrickhulce
patrickhulce approved these changes May 17, 2021
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't understand why we need it, but seems cool :)

@connorjclark
Copy link
Collaborator Author

when a node is zoomed treemap lib might make more nodes. the color is set via inline CSS outside treemap lib app. so if there are more nodes we need to recolor. there's some code just before for click that does the same thing.

@connorjclark connorjclark merged commit fe4cced into master May 17, 2021
@connorjclark connorjclark deleted the treemap-enter-colors branch May 17, 2021 23:21
@patrickhulce patrickhulce mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees

@patrickhulce patrickhulce

Labels
cla: yes waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@connorjclark @patrickhulce @devtools-bot