tests: avoid node 16.9.0 #13012
Merged
tests: avoid node 16.9.0 #13012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested review from
connorjclark
and removed request for
a team
brendankenny
approved these changes
Sep 7, 2021
|
we'll have to remove node 16 as the required check because the name change (or add a label/mutate the version to derive a label so it's still "node 16") |
Done. After this lands, other open PRs will need to at least kick their |
satya-nutella
pushed a commit
to satya-nutella/lighthouse
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes our unit tests by avoiding the jest crash in node 16.9.0
Related Issues/PRs
see nodejs/node#40030