docs(contributing): update pass, and link to google doc guide #14445
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexnj
reviewed
Oct 13, 2022
alexnj
approved these changes
Oct 13, 2022
| @@ -2,27 +2,30 @@ | |||
|
|
|||
| We'd love your help! This doc covers how to become a contributor and submit code to the project. | |||
|
|
|||
| Additonal guidance can be found on [this google doc](https://docs.google.com/document/d/118a05zwIN2_Qhw7ZNmxdg2rLbatoeIcG6i-aYedzsp4/edit?usp=sharing). | |||
There was a problem hiding this comment.
I wrote this doc some time ago with a different audience in mind, someone also fresh to web dev. I didn't want to reformat into this markdown. I can just as well remove it entirely.
Co-authored-by: Brendan Kenny <bckenny@gmail.com>
connorjclark
force-pushed
the
contrib-update
branch
from
69a5660
to
30618fa
Compare
|
Would love to see some code style formatters included within the guide. It makes it more difficult to contribute if there's no automatic style applied by a code editor, and results in Team LH having to police formatting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.