report: improve some usages of css grid #14715
Open
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reviewed our usages of CSS grid, and found two things to improve:
drop
grid-auto-rows: 1fr
on metrics containerminor visual change, stops giving rows all the same height. was no good reason for this i think. it's just more whitespace.
simplify
grid-template-columns
on inner metric divwe were manually calculating how much space to give the first column by listing out how big that status icon should be. instead, we can just use
auto
. no visual change