core: compute TBT impact for main thread tasks #15175
Merged
+600
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Jun 14, 2023
| @@ -60,7 +60,7 @@ class TotalBlockingTime extends ComputedMetric { | |||
| timing: calculateSumOfBlockingTime( | |||
| events, | |||
| 0, | |||
| data.processedTrace.timestamps.traceEnd | |||
| data.processedTrace.timings.traceEnd | |||
There was a problem hiding this comment.
Pretty sure this is a bug, but doesn't affect anything in practice. Timespan should just calculate the blocking time for the entire trace anyway.
2 tasks
adamraine
changed the title
adamraine
commented
Jun 29, 2023
| @@ -41,7 +41,6 @@ | |||
| "core/test/config/config-plugin-test.js", | |||
| "core/test/legacy/config/config-test.js", | |||
| "core/test/config/default-config-test.js", | |||
| "core/test/create-test-trace.js", | |||
There was a problem hiding this comment.
Type checking the new test file requires this to be type checked as well, so there are some changes to artifacts.d.ts and create-test-trace.js so it passes the type check.
connorjclark
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned here, some long tasks that appear in the trace are not added to TBT because they are outside the bounds of TBT (Starting at FCP and ending at TTI).
This PR adds a computed artifact to calculate the impact each individual main thread task has on TBT. A downstream performance audit will use this to calculate the TBT savings for main thread tasks that are in scope for that audit. I expect to use this to calculate TBT savings in the following audits: