audit(non-composited-animations): add UIString for custom properties #15571
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with-shrey
changed the title
adamraine
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Can you add a new unit test to this file:
https://github.com/GoogleChrome/lighthouse/blob/main/core/test/audits/non-composited-animations-test.js#L1
| @@ -91,9 +101,18 @@ function getActionableFailureReasons(failureCode, unsupportedProperties) { | |||
| .filter(reason => failureCode & reason.flag) | |||
| .map(reason => { | |||
| if (reason.text === UIStrings.unsupportedCSSProperty) { | |||
| const nonCustomUnSupportedProperties = unsupportedProperties | |||
| .filter(property => !property.startsWith('--')); | |||
There was a problem hiding this comment.
nit
Suggested change
| .filter(property => !property.startsWith('--')); | |
| .filter(property => !property.startsWith('--')); |
| @@ -91,9 +101,18 @@ function getActionableFailureReasons(failureCode, unsupportedProperties) { | |||
| .filter(reason => failureCode & reason.flag) | |||
| .map(reason => { | |||
| if (reason.text === UIStrings.unsupportedCSSProperty) { | |||
| const nonCustomUnSupportedProperties = unsupportedProperties | |||
There was a problem hiding this comment.
Suggested change
| const nonCustomUnSupportedProperties = unsupportedProperties | |
| const nonCustomUnsupportedProperties = unsupportedProperties |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Animating custom properties appear to always end up non-composited (at least outside of CSS painting), and get lumped with all the other non-composited CSS properties found in the trace (don't be surprised like me and note that this happens regardless of what the property is animating, e.g. animating translate through fixed values is usually composited, animating --yheight in translate: 0 var(--yheight) will not be).
Related Issues/PRs
Closes #14521