core: Optimize asynchronous task executions ✈ #15715
Open
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjaiyan-dev
requested review from
adamraine
and removed request for
a team
sanjaiyan-dev
changed the title
Promise.all for Improved Performance ✈Promise.all for Performance ✈
sanjaiyan-dev
changed the title
Promise.all for Performance ✈Promise.all for Performance ✈
sanjaiyan-dev
changed the title
Promise.all for Performance ✈Lint fix
|
Done :) |
|
Thanks for the PR! However, there may be a couple faster things in here, but most I think are no faster and just harder to read. There's no I/O work happening in most of these these aync tasks - so I'd expect this to not be beneficial for those tasks. Do you have performance numbers to back it up? w/o, I'd prefer to keep the current more easily readable/writable/blameable code. |
|
Hi @connorjclark, Sorry for the delayed response. I hope the current code changes are correct, and I apologize for any inconvenience. 🫱🏼🫲🏾 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request introduces a performance improvement by executing asynchronous tasks concurrently using
Promise.all. This enhancement aims to optimize the efficient utilization of hardware resources.This PR draws inspiration from a similar one (though not identical) in the Deno runtime, where the execution time was reduced by 85% through concurrent processing. For reference, please see: denoland/deno_std#3363.
Thank you for considering these enhancements.