tests: finish removing mocha #7429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
changed the title
brendankenny
changed the title
brendankenny
commented
Mar 9, 2019
| @@ -1046,7 +1046,7 @@ describe('Config', () => { | |||
|
|
|||
| it('loads a gatherer from node_modules/', () => { | |||
| // Use a lighthouse dep as a stand in for a module. | |||
| assert.throws(_ => loadGatherer('mocha'), function(err) { | |||
| assert.throws(_ => loadGatherer('lighthouse-logger'), function(err) { | |||
There was a problem hiding this comment.
these are testing that Config.resolveModule will look in node_modules/ for audits or gatherers, so it just needs to be something in there.
brendankenny
commented
Mar 9, 2019
| @@ -50,7 +50,6 @@ | |||
| "fast": "yarn start --disable-device-emulation --throttlingMethod=provided", | |||
| "deploy-viewer": "yarn build-viewer --deploy", | |||
| "bundlesize": "bundlesize", | |||
| "plots-smoke": "bash plots/test/smoke.sh", | |||
brendankenny
commented
Mar 9, 2019
| @@ -138,12 +137,10 @@ | |||
| "configstore": "^3.1.1", | |||
| "cssstyle": "1.2.1", | |||
| "details-element-polyfill": "2.2.0", | |||
| "esprima": "^4.0.1", | |||
There was a problem hiding this comment.
still used by collect-strings.js, but no longer in unminified-javascript, so just a devDependency
no dice |
brendankenny
changed the title
|
"fix CI errors" -> lies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another possible approach to fixing #7418/#7413, assuming something wonky is going on trying to do coverage over jest and mocha at once.
If it doesn't work...we've been meaning to finish getting rid of mocha anyways :)