Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update bundlesize, add more budgets #9089

Merged
merged 1 commit into from
May 31, 2019
Merged

deps: update bundlesize, add more budgets #9089

merged 1 commit into from
May 31, 2019

Conversation

brendankenny
Copy link
Member

@brendankenny brendankenny commented May 30, 2019

bundlesize has been having a bunch of issues in CI lately, and now there's a moderate security alert in one of its deps, so let's try bumping it to latest.

Unfortunately it brings in a rather heavyweight dep itself in a native brotli encoding library, but development seems to be picking back up again (siddharthkp/bundlesize#306) and that'll soon be optional if the node version has native brotli support.

Also added budgets for the other bundles as they vary quite a bit in size due to things included or not included in them.

@brendankenny
Copy link
Member Author

If this doesn't work, we could also try out bundlewatch, which has a pretty nice details page for the bundle sizes

but doesn't have such a large community using it. https://bundlewatch.io/#/getting-started/using-bundlewatch

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boo to native dependencies :(

LGTM

+1 to dumping if it gets bad

@brendankenny
Copy link
Member Author

well, the initial api call is still 500ing...I think that's when it's trying to query the bundlesize from the parent commit (hence the -null in the status).

We need to update anyways and I think the new status message is improved (even better when it can start querying master so we get some update on size change in that PR), so still worth landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants