Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not land] Add support for experimental Layout Shift Normalized values #120

Closed
wants to merge 3 commits into from

Conversation

mmocny
Copy link
Member

@mmocny mmocny commented Jan 22, 2021

No description provided.

@google-cla
Copy link

google-cla bot commented Jan 22, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mmocny mmocny changed the title Lsn [Do not land] Add support for experimental Layout Shift Normalized values Jan 22, 2021
@mmocny
Copy link
Member Author

mmocny commented Jan 22, 2021

@philipwalton This isn't meant to land into master, but I was not sure how to open a PR to compare with master, but to request landing in a separate branch.

Besides the getLSN implementation, I expect the most contentious change was to add support for getting multiple values back via ReportHandler, and the fairly convoluted accompanying change to bindReporter to enable that.

(I haven't added test suite for any of this yet, but did wrote some manual tests and compared to chrome UKM on sample sites manually.)

@philipwalton
Copy link
Member

Closing this now the #148 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants