Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates README links. #401

Merged
merged 2 commits into from Nov 25, 2023
Merged

Updates README links. #401

merged 2 commits into from Nov 25, 2023

Conversation

malchata
Copy link
Member

Updates links in the README:

  • Various links in the web-vitals README are out of sync with web.dev since its migration to devsite. Links in the README currently go through a redirect, or worse, link to specific sections of web.dev articles where header IDs are no longer valid.
  • Removes the localization in MDN links (e.g., links contain /en-US/).

tunetheweb
tunetheweb requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you could update the references in the code while you're at it?

https://github.com/search?q=repo%3AGoogleChrome%2Fweb-vitals%20https%3A%2F%2Fweb.dev&type=code

@tunetheweb tunetheweb merged commit 16e6e93 into GoogleChrome:main Nov 25, 2023
2 checks passed
@malchata malchata deleted the updates-readme-links branch November 25, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malchata @tunetheweb