New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split waitingDuration
to make it easier to understand redirect delays
#458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
requested changes
Apr 4, 2024
philipwalton
reviewed
Apr 4, 2024
tunetheweb
changed the title
Redirect duration
Split waitingDuration to make it easier to understand redirect delays
Apr 12, 2024
tunetheweb
changed the title
Split waitingDuration to make it easier to understand redirect delays
Split Apr 12, 2024
waitingDuration
to make it easier to understand redirect delays
philipwalton
requested changes
Apr 12, 2024
philipwalton
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #395
This splits
waitingDuration
(formerly known aswaitingTime
in v3) into two:waitingDuration
- which the time until (workerStart
orfetchStart
). This will mostly be redirect time but I've avoided explicitly calling that asredirectStart/End
can't be used and it's easy to see when testing instances where looking atworkerStart
orfetchStart
still leaves a non-0 amount of time that is not redirects.cacheDuration
which is the time from then untildomainLookupStart
. This will mostly be HTTP cache time, except for service-worker controlled sites when it will be service worker time.See PerformanceNavigationTiming breakdown for more context:
As part of this I've also moved any delays between
connectEnd
andrequestStart
from being attributed toconnectionDuration
(i.e before the delay) torequestDuration
(i.e after the delay). This helps avoiding attributing this delay toconnectionDuration
for service-worker controlled sites when this should be 0, but without adding an extra breakdown that would not be that useful.