Fix reportAllChanges behavior for LCP when library is loaded late
#468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what's gling on with the Firefox test. Unrelated to this PR and seems it's using v127.0a1 instead of v125.0.1 (the last successful run 2 days ago) so a dependency upgrade and seems to be ahead of stable now. Will keep digging... |
|
OK I think it's just a case of Firefox Nightly being a bit broken at the mo. Will try rerunning this tomorrow. |
philipwalton
requested changes
Apr 26, 2024
philipwalton
approved these changes
Apr 29, 2024
philipwalton
changed the title
reportAllChanges behavior for LCP when library is loaded late
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if
reportAllChanges=truebut web-vitals is loaded late, then it doesn't report all LCP changes as we take the last one.This can be confusing and make you think only one LCP entry was emitted when multiple ones were. It can be useful to know that multiple entries are emitted and this works for all the other metrics.
I also removed some "// Greater than the image load delay." comments that weren't true.