Change swSrc validation (#2451)

GoogleChrome · Apr 13, 2020 · 18939e4 · 18939e4
1 parent 0f2ffda
commit 18939e4
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 45 deletions.
diff --git a/packages/workbox-cli/src/lib/assert-valid-sw-src.js b/packages/workbox-cli/src/lib/assert-valid-sw-src.js
diff --git a/packages/workbox-cli/src/lib/questions/ask-sw-src.js b/packages/workbox-cli/src/lib/questions/ask-sw-src.js
@@ -9,8 +9,6 @@
 const inquirer = require('inquirer');
 const ol = require('common-tags').oneLine;
 
-const assertValidSWSrc = require('../assert-valid-sw-src');
-
 // The key used for the question/answer.
 const name = 'swSrc';
 
@@ -29,9 +27,5 @@ function askQuestion() {
 
 module.exports = async () => {
   const answers = await askQuestion();
-  const swSrc = answers[name].trim();
-
-  await assertValidSWSrc(swSrc);
-
-  return swSrc;
+  return answers[name].trim();
 };
diff --git a/test/workbox-cli/node/lib/questions/ask-sw-src.js b/test/workbox-cli/node/lib/questions/ask-sw-src.js
@@ -15,30 +15,12 @@ const MODULE_PATH = '../../../../../packages/workbox-cli/src/lib/questions/ask-s
 const QUESTION_NAME = 'swSrc';
 
 describe(`[workbox-cli] lib/questions/ask-sw-src.js`, function() {
-  it(`should reject when the valid SW assertion fails`, async function() {
-    const injectedError = new Error('injected error');
-    const askSWSrc = proxyquire(MODULE_PATH, {
-      'inquirer': {
-        prompt: () => Promise.resolve({[QUESTION_NAME]: ''}),
-      },
-      '../assert-valid-sw-src': () => Promise.reject(injectedError),
-    });
-
-    try {
-      await askSWSrc();
-      throw new Error('Unexpected success.');
-    } catch (error) {
-      expect(error).to.eql(injectedError);
-    }
-  });
-
   it(`should resolve with a valid answer to the question`, async function() {
     const expectedAnswer = 'expected answer';
     const askSWSrc = proxyquire(MODULE_PATH, {
       'inquirer': {
         prompt: () => Promise.resolve({[QUESTION_NAME]: expectedAnswer}),
       },
-      '../assert-valid-sw-src': () => Promise.resolve(),
     });
 
     const answer = await askSWSrc();