Skip to content

Commit

Permalink
Fixes workbox dependencies (#1667)
Browse files Browse the repository at this point in the history
* Fixes workbox dependencies

* Fixes the depcheck
  • Loading branch information
arcanis authored and jeffposnick committed Sep 28, 2018
1 parent 3612461 commit 9666462
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 1 deletion.
23 changes: 22 additions & 1 deletion packages/workbox-webpack-plugin/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/workbox-webpack-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"node": ">=4.0.0"
},
"dependencies": {
"babel-runtime": "^6.26.0",
"json-stable-stringify": "^1.0.1",
"workbox-build": "^3.6.1"
},
Expand Down
3 changes: 3 additions & 0 deletions test/workbox-webpack-plugin/node/dependency-check.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ describe(`[workbox-webpack-plugin] Test Dependencies`, function() {
'build',
'demo',
],
ignoreMatches: [
'babel-runtime',
],
}, (unusedDeps) => {
if (unusedDeps.dependencies.length > 0) {
return reject(new Error(`Unused dependencies defined in package.json: ${JSON.stringify(unusedDeps.dependencies)}`));
Expand Down

0 comments on commit 9666462

Please sign in to comment.