Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add minification for the cli and webpack-plugin #2026

Closed
wants to merge 1 commit into from
Closed

feat: add minification for the cli and webpack-plugin #2026

wants to merge 1 commit into from

Conversation

wood1986
Copy link

@wood1986 wood1986 commented Apr 11, 2019

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jeffposnick
Copy link
Contributor

Thanks for the contribution, @wood1986!

We're in the process of rewriting the workbox-webpack-plugin along the lines of the proposal outlined at #1854 (Work on this has actually begun!)

Given that, I don't think it makes sense to move forward with this PR at this time. The rewrite to the plugin will result in a compiled service worker that takes advantage of minification.

@wood1986
Copy link
Author

wood1986 commented Apr 13, 2019

@jeffposnick how does it take to release v5? if it is longer than 3 months, is it possible to accept the merge?

@jeffposnick
Copy link
Contributor

There were some open questions about staffing this effort that have been resolved, and work on the workbox-webpack-plugin v5 has begun. Unfortunately, I can't offer any guarantees around timelines for the release.

I do not believe it makes sense to make fundamental changes to the plugin's behavior in v4 while that effort is underway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workbox-build: generate minified output?
3 participants