Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy handleMake from serviceworker-webpack-plugin #2060

Closed
wants to merge 1 commit into from

Conversation

ALiangLiang
Copy link

Prior to filing a PR, please:

  • open an issue to discuss your proposed change.
  • ensure that gulp lint test passes locally.

R: @jeffposnick @philipwalton

Fixes #1513

Description of what's changed/fixed.

Compile the serviceworker with webpack.

@jeffposnick
Copy link
Contributor

Hello!

I appreciate the fact that this is something that many folks in the community would like. I'm actively working towards bringing this functionality to Workbox v5—part of this is outlined in #1854, but there are also some underlying changes being made to the workbox-build library that will factor in to the rewrite as well.

Because of this, I'd much rather address this use case as part of the official v5 revised interface. I'm more than happy that folks from the community who are not satisfied with the v4 behavior have found their own solutions in the meantime, but I do not want to incorporate them into the official v4 release piecemeal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InjectManifest Plugin doesn't compile the serviceworker with webpack
2 participants