Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various npm dependency bumps #2369

Merged
merged 4 commits into from Mar 4, 2020
Merged

Various npm dependency bumps #2369

merged 4 commits into from Mar 4, 2020

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton

No breaking changes in the dependencies that I could see.

We had gotten pretty far behind on the various Rollup plugins in particular, as the "official" ones had all been renamed to @rollup/plugin-....

Copy link
Member

@philipwalton philipwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once merge conflicts are resolved.

@jeffposnick
Copy link
Contributor Author

(I had to rename a few files that were still using require() instead of import from .mjs to .js, because as of mochajs/mocha#4038, mocha requires that any file with the .mjs extension to only use import.)

@philipwalton
Copy link
Member

Ahh, yeah and that fits with Node ESM requirements as well.

@jeffposnick jeffposnick merged commit 4f4f977 into master Mar 4, 2020
@jeffposnick jeffposnick deleted the deps-update branch March 4, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants