-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/recipes precache and normalize #2718
Merged
jeffposnick
merged 8 commits into
GoogleChrome:v6
from
Snugug:feature/recipes-precache-and-normalize
Jan 15, 2021
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
24e8d4c
Add warmStrategyCache recipe
Snugug f2b1f2b
Add warmCache and plugins options
Snugug 032d0d7
Remove offlineFallback dependency on precache
Snugug 482a947
Add missing newline
Snugug ba58724
Export warmStrategyCache
Snugug 2dfdebc
Update packages/workbox-recipes/src/warmStrategyCache.ts
Snugug 3fe548a
Rename 'warm' and 'paths'
Snugug 8e689bb
Update dependencies to use 'urls' instead of 'paths'
Snugug File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import { Strategy } from 'workbox-strategies/src/Strategy'; | ||
|
||
import './_version.js'; | ||
|
||
export interface WarmStrategyCacheOptions { | ||
paths: Array<string>; | ||
strategy: Strategy; | ||
} | ||
|
||
// Give TypeScript the correct global. | ||
declare let self: ServiceWorkerGlobalScope; | ||
|
||
/** | ||
* | ||
Snugug marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* @param {Object} options | ||
* @param {string[]} options.paths Paths to warm the strategy's cache with | ||
* @param {Strategy} options.strategy Strategy to use | ||
*/ | ||
function warmStrategyCache(options: WarmStrategyCacheOptions): void { | ||
self.addEventListener('install', event => { | ||
const warm = options.paths.map(path => options.strategy.handleAll({ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think |
||
event, | ||
request: new Request(path), | ||
})[1]); | ||
|
||
event.waitUntil(Promise.all(warm)); | ||
}); | ||
} | ||
|
||
export {warmStrategyCache}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you switch from calling this
paths
tourls
?(As far as I can tell, you should be able to pass in any absolute or relative URL inside this array, right?)