Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for multiple chunks emitting to ssr-bundle.js #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dwoznicki
Copy link

Prerendering multiple entries in conjunction with the {{prerender}} injection point results in the following error:

Error: Conflict: Multiple chunks emit assets to the same filename ssr-bundle.js

even when an entry is specified in the loader query string for HtmlWebpackPlugin template.

const plugin = new HtmlWebpackPlugin({
  // ...
  template: `!!prerender-loader?string&entry=${entryFile}!./src/template.html`
});

This appears to be caused by this block clobbering the original entry and changing it to undefined.

if (matches) {
  inject = true;
  options.entry = matches[1]; // <-- matches[1] is `undefined`
}

I'm not sure what the original intention here is, but only reassigning the entry if it's not already set probably fixes the issue. I can't say for sure because I can't build due to developit/microbundle#74. Making this change directly to dist/prerender-loader.js worked for me.

Fixes #29 (comment)

…h {{prerender}} injection injection point fails with:

  Error: Conflict: Multiple chunks emit assets to the same filename ssr-bundle.js
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dwoznicki
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@vzaidman
Copy link

Wow I was about to open a similar PR and developit/microbundle#74 stopped me from making sure it works.

anyway- thumbs up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Conflict: Multiple chunks emit assets to the same filename ssr-bundle.js
3 participants