request-idle-callback.mjs: switch to a named export #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
xmr/named-export
branch
3 times, most recently
from
c341b03
to
bc9d669
Compare
|
I would agree that considering this a breaking change for the next major may make sense. Created a label for us to distinguish which changes should be saved for 3.0 vs can land earlier. |
addyosmani
approved these changes
Apr 26, 2023
XhmikosR
force-pushed
the
xmr/named-export
branch
from
bc9d669
to
99cc680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: Can this be considered a breaking change? AFAICT this is not public API, but if it's considered a BC let's postpone it for v3.0.0.