Modified parameters descriptions as per public doc #1480

sharan-malyala · 2024-04-27T04:30:04Z

Changed descriptions for dataflow templates

…b template

damccorm

Did a partial review - my overarching feedback is that overall this looks good to me, but we should not remove or replace the example fields since those will get autogenerated when we generate docs. Could you fix that up in all the locations where we remove example, then I'll do a full review?

v1/src/main/java/com/google/cloud/teleport/bigtable/BigtableToVectorEmbeddings.java

damccorm

Looks great! Had comments, but they're all minor

...to-googlecloud/src/main/java/com/google/cloud/teleport/v2/options/JdbcToBigQueryOptions.java

...ommon/src/main/java/com/google/cloud/teleport/v2/bigtable/options/BigtableCommonOptions.java

...n/src/main/java/com/google/cloud/teleport/v2/options/BigQueryStorageApiStreamingOptions.java

...to-googlecloud/src/main/java/com/google/cloud/teleport/v2/templates/GoogleAdsToBigQuery.java

...y-to-bigquery/src/main/java/com/google/cloud/teleport/v2/templates/PubsubAvroToBigQuery.java

rszper

Will the code ticks render in devsite? I left them all as is, but I'm not sure if they just remain ticks or if the text renders as code. Also, we're not using them consistently in this content.

v1/src/main/java/com/google/cloud/teleport/bigtable/BigtableToVectorEmbeddings.java

v1/src/main/java/com/google/cloud/teleport/bigtable/CassandraToBigtable.java

...src/main/java/com/google/cloud/teleport/v2/options/BigtableChangeStreamsToPubSubOptions.java

...to-googlecloud/src/main/java/com/google/cloud/teleport/v2/options/JdbcToBigQueryOptions.java

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>

v1/src/main/java/com/google/cloud/teleport/bigtable/CassandraToBigtable.java

v1/src/main/java/com/google/cloud/teleport/options/CommonTemplateOptions.java

v1/src/main/java/com/google/cloud/teleport/options/WindowedFilenamePolicyOptions.java

v1/src/main/java/com/google/cloud/teleport/templates/PubsubToText.java

...src/main/java/com/google/cloud/teleport/v2/options/BigtableChangeStreamsToPubSubOptions.java

...to-googlecloud/src/main/java/com/google/cloud/teleport/v2/options/JdbcToBigQueryOptions.java

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>

sharan-malyala · 2024-05-03T02:02:56Z

Resolved conflicts with base branch.
@damccorm Request review and approval.

...to-googlecloud/src/main/java/com/google/cloud/teleport/v2/options/JdbcToBigQueryOptions.java

...ommon/src/main/java/com/google/cloud/teleport/v2/bigtable/options/BigtableCommonOptions.java

codecov · 2024-05-03T15:00:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.26%. Comparing base (ee6f318) to head (623e467).

❗ Current head 623e467 differs from pull request most recent head 12b84a1. Consider uploading reports for the commit 12b84a1 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1480      +/-   ##
============================================
+ Coverage     39.89%   40.26%   +0.36%     
- Complexity     2782     2815      +33     
============================================
  Files           750      740      -10     
  Lines         42568    42899     +331     
  Branches       4555     4604      +49     
============================================
+ Hits          16983    17272     +289     
- Misses        24118    24136      +18     
- Partials       1467     1491      +24

Components	Coverage Δ
spanner-templates	`56.82% <ø> (+0.11%)`	⬆️
spanner-import-export	`65.59% <ø> (+0.02%)`	⬆️
spanner-live-forward-migration	`63.17% <ø> (+1.93%)`	⬆️
spanner-live-reverse-replication	`42.95% <ø> (+0.42%)`	⬆️
spanner-bulk-migration	`69.97% <ø> (-2.03%)`	⬇️

Files	Coverage Δ
.../teleport/bigtable/BigtableToVectorEmbeddings.java	`78.33% <ø> (ø)`
...e/cloud/teleport/bigtable/CassandraToBigtable.java	`0.00% <ø> (ø)`
...gle/cloud/teleport/bigtable/ParquetToBigtable.java	`57.14% <ø> (ø)`
.../google/cloud/teleport/templates/PubsubToText.java	`0.00% <ø> (ø)`
...teleport/templates/common/DatastoreConverters.java	`62.67% <ø> (ø)`
...oud/teleport/templates/common/ErrorConverters.java	`66.32% <ø> (ø)`
...loud/teleport/templates/common/TextConverters.java	`0.00% <ø> (ø)`
...e/cloud/teleport/v2/templates/DataStreamToSQL.java	`4.76% <ø> (ø)`
...oud/teleport/v2/templates/GoogleAdsToBigQuery.java	`0.00% <ø> (ø)`
...ud/teleport/v2/templates/PubsubAvroToBigQuery.java	`0.00% <ø> (ø)`

... and 85 files with indirect coverage changes

...ommon/src/main/java/com/google/cloud/teleport/v2/bigtable/options/BigtableCommonOptions.java

damccorm

Thanks!

rszper

A handful of small updates. Otherwise, LGTM.

v1/src/main/java/com/google/cloud/teleport/bigtable/CassandraToBigtable.java

v1/src/main/java/com/google/cloud/teleport/options/WindowedFilenamePolicyOptions.java

v2/common/src/main/java/com/google/cloud/teleport/v2/options/BigQueryCommonOptions.java

v2/datastream-to-sql/src/main/java/com/google/cloud/teleport/v2/templates/DataStreamToSQL.java

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>

Modified parameters descriptions as per public doc

4734523

pull-request-size bot added the size/S label Apr 27, 2024

Modified parameters for bigtable to vector embeddings template

fc13f52

pull-request-size bot added size/M and removed size/S labels Apr 27, 2024

sharan-malyala added 5 commits April 27, 2024 16:00

Modified missing parameters for bigtable to vector embeddings template

e8b30fd

Modified parameters descriptions for gcs to bigtable template

b82587a

Modified parameters descriptions for text to datastore template

26bc39c

Modified parameters descriptions for google ads to bigquery template

8492e30

Modified parameters for PubSub avro to Bigquery template

584aebb

pull-request-size bot added size/L and removed size/M labels Apr 28, 2024

sharan-malyala added 5 commits April 28, 2024 07:03

Modified parameters descriptions for DataStream to SQL template

5eb4f7c

Modified parameters descriptions for PubSub to text template

b5fd4cb

pubsub text to java changes

62326bf

Modified parameters for Oracle to Bigquery template

c17a793

Modified parameter descriptions for Bigtable change streams to Pub/Su…

7a4286a

…b template

sharan-malyala marked this pull request as ready for review April 29, 2024 06:38

damccorm reviewed Apr 29, 2024

View reviewed changes

v1/src/main/java/com/google/cloud/teleport/bigtable/BigtableToVectorEmbeddings.java Outdated Show resolved Hide resolved

sharan-malyala added 2 commits April 29, 2024 20:59

reverted example properties

c3ab422

reverted example

19257d0

damccorm reviewed Apr 29, 2024

View reviewed changes

rszper reviewed Apr 29, 2024

View reviewed changes

sharan-malyala and others added 5 commits April 30, 2024 11:10

Apply suggestions from code review

03f0a42

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>

reverted the links

57c21d1

changed a description

6c048c9

pull origin

d4a8841

Apply suggestions from code review

78c92bf

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>

rszper reviewed May 1, 2024

View reviewed changes

Apply suggestions from code review

64443e5

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>

sharan-malyala added 2 commits May 3, 2024 07:07

modified DayPattern parameter

1dc745f

Merge branch 'main' into sharantej-dataflowTemplates

f7e8acc

sharan-malyala commented May 3, 2024

View reviewed changes

...to-googlecloud/src/main/java/com/google/cloud/teleport/v2/options/JdbcToBigQueryOptions.java Outdated Show resolved Hide resolved

sharan-malyala commented May 3, 2024

View reviewed changes

...to-googlecloud/src/main/java/com/google/cloud/teleport/v2/options/JdbcToBigQueryOptions.java Outdated Show resolved Hide resolved

sharan-malyala commented May 3, 2024

View reviewed changes

...ommon/src/main/java/com/google/cloud/teleport/v2/bigtable/options/BigtableCommonOptions.java Outdated Show resolved Hide resolved

damccorm reviewed May 3, 2024

View reviewed changes

...ommon/src/main/java/com/google/cloud/teleport/v2/bigtable/options/BigtableCommonOptions.java Outdated Show resolved Hide resolved

rszper reviewed May 3, 2024

View reviewed changes

...ommon/src/main/java/com/google/cloud/teleport/v2/bigtable/options/BigtableCommonOptions.java Outdated Show resolved Hide resolved

sharan-malyala added 3 commits May 4, 2024 06:06

applied suggestions

b1dc28d

removed optional from a description

27fa668

ran spotless:apply

d163e07

damccorm approved these changes May 6, 2024

View reviewed changes

damccorm added the Google LGTM Approval of a pull request to be merged into the repository label May 6, 2024

rszper approved these changes May 6, 2024

View reviewed changes

Apply suggestions from code review

52181f7

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>

rszper approved these changes May 7, 2024

View reviewed changes

sharan-malyala added 3 commits May 8, 2024 04:25

Merge branch 'GoogleCloudPlatform:main' into sharantej-dataflowTemplates

d9916c4

Merge branch 'GoogleCloudPlatform:main' into sharantej-dataflowTemplates

623e467

Merge branch 'GoogleCloudPlatform:main' into sharantej-dataflowTemplates

12b84a1

copybara-service bot merged commit 3a154b6 into GoogleCloudPlatform:main May 11, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modified parameters descriptions as per public doc #1480

Modified parameters descriptions as per public doc #1480

sharan-malyala commented Apr 27, 2024 •

edited

damccorm left a comment

damccorm left a comment

rszper left a comment

sharan-malyala commented May 3, 2024

codecov bot commented May 3, 2024 •

edited

damccorm left a comment

rszper left a comment

Modified parameters descriptions as per public doc #1480

Modified parameters descriptions as per public doc #1480

Conversation

sharan-malyala commented Apr 27, 2024 • edited

damccorm left a comment

Choose a reason for hiding this comment

damccorm left a comment

Choose a reason for hiding this comment

rszper left a comment

Choose a reason for hiding this comment

sharan-malyala commented May 3, 2024

codecov bot commented May 3, 2024 • edited

Codecov Report

damccorm left a comment

Choose a reason for hiding this comment

rszper left a comment

Choose a reason for hiding this comment

sharan-malyala commented Apr 27, 2024 •

edited

codecov bot commented May 3, 2024 •

edited