Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support conversion of RFC4180 CSV #1514

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kylase
Copy link

@kylase kylase commented May 4, 2024

This PR improves StringToGenericRecordFn, which uses Guava's Splitter, to split a CSV string. This method does not support RFC4180 CSV which could have the comma delimiter within the field value, e.g. 007,"CA,AZ",26.23.

This requires the Apache Commons CSV library to be updated as well as CSVRecord.values method is not public in 1.8.

Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 39.89%. Comparing base (ee6f318) to head (4ad906d).
Report is 30 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1514      +/-   ##
============================================
- Coverage     39.89%   39.89%   -0.01%     
- Complexity     2782     2783       +1     
============================================
  Files           750      750              
  Lines         42568    42574       +6     
  Branches       4555     4555              
============================================
+ Hits          16983    16985       +2     
- Misses        24118    24123       +5     
+ Partials       1467     1466       -1     
Components Coverage Δ
spanner-templates 56.73% <ø> (+0.01%) ⬆️
spanner-import-export 65.61% <ø> (+0.04%) ⬆️
spanner-live-forward-migration 61.23% <ø> (ø)
spanner-live-reverse-replication 42.53% <ø> (ø)
spanner-bulk-migration 72.00% <ø> (ø)
Files Coverage Δ
...le/cloud/teleport/v2/transforms/CsvConverters.java 70.80% <62.50%> (-0.52%) ⬇️

... and 3 files with indirect coverage changes

@kylase kylase force-pushed the fix/support-rfc4180-string-to-genericrecord branch from cbde926 to 73fd5f7 Compare May 7, 2024 14:58
@kylase kylase force-pushed the fix/support-rfc4180-string-to-genericrecord branch from 73fd5f7 to 4ad906d Compare May 11, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant