Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch DatastreamToSpannerDataTypeIT from JSON to Avro #1525

Merged

Conversation

manitgupta
Copy link
Member

The current ITs use JSON data from Datastream which is not used in actual migrations.

Switching ITs to use avro files from Datastream instead of JSON to more closely resemble a production scenario. This involves generating all the test data and verifying that assertions are correct.

@manitgupta manitgupta requested a review from a team as a code owner May 7, 2024 11:58
@manitgupta manitgupta requested review from Deep1998 and krishnamoorthy-r and removed request for a team May 7, 2024 11:58
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@ace900d). Click here to learn what that means.
Report is 35 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1525   +/-   ##
=======================================
  Coverage        ?   40.08%           
  Complexity      ?     2804           
=======================================
  Files           ?      754           
  Lines           ?    42710           
  Branches        ?     4587           
=======================================
  Hits            ?    17121           
  Misses          ?    24110           
  Partials        ?     1479           
Components Coverage Δ
spanner-templates 56.75% <ø> (?)
spanner-import-export 65.59% <ø> (?)
spanner-live-forward-migration 61.31% <ø> (?)
spanner-live-reverse-replication 42.63% <ø> (?)
spanner-bulk-migration 72.05% <ø> (?)

Copy link
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darshan-sj darshan-sj added the Google LGTM Approval of a pull request to be merged into the repository label May 9, 2024
@copybara-service copybara-service bot merged commit 5fa3150 into GoogleCloudPlatform:main May 9, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Google LGTM Approval of a pull request to be merged into the repository size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants