Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs with DevAppServer and EE8 #188

Merged
merged 7 commits into from
May 14, 2024
Merged

Conversation

lachlan-roberts
Copy link
Collaborator

  • “IllegalStateException: Committed” after 403 Forbidden sent by DefaultServlet when directory listing is now allowed.
  • Investigate and fix classloading issues not being able to load jetty-servlet classes from the web.xml configuration.
  • Fix the redirect loop issue in the LocalResourceFileServlet.
  • Use the startWebApp() method introduced in 12.0.8 for EE8 AppEngineWebAppContext.
  • NullPointerException caused because the HtmlEscaper rejects null value for the error message from the ResponseRewriteFilter.
  • Fix java.lang.IllegalStateException: Response has already been committed, because the ResponseRewriterFilter.ResponseWrapper was committing the response twice.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…t with DevAppServer

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@ludoch
Copy link
Collaborator

ludoch commented May 14, 2024

We will need a regression test both for EE 8 and EE 10.

@ludoch
Copy link
Collaborator

ludoch commented May 14, 2024

Also for the record, the regression was introduced in https://github.com/GoogleCloudPlatform/appengine-java-standard/pull/105/files

@ludoch
Copy link
Collaborator

ludoch commented May 14, 2024

We will wait for the regression test, approving only for nighty build

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@copybara-service copybara-service bot merged commit cb3c8b3 into main May 14, 2024
9 checks passed
@copybara-service copybara-service bot deleted the devappserver-debugging branch May 14, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants