Add entrypoint extraction to AppYaml parser #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
loosebazooka
force-pushed
the
entrypoint-to-appyaml
branch
from
cb13437
to
33237bf
Compare
|
rebased, this should be ready for review |
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
=========================================
Coverage 78.45% 78.46%
- Complexity 609 610 +1
=========================================
Files 96 96
Lines 2409 2410 +1
Branches 282 282
=========================================
+ Hits 1890 1891 +1
Misses 411 411
Partials 108 108
Continue to review full report at Codecov.
|
chanseokoh
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #840
also fixes some naming in tests.
NOTE: build is broken because of #841