Cloud functions ingest: backfill CLI tool + minor improvements #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tils into cloud-functions-ingest
…tils into cloud-functions-ingest
danieldeleo
reviewed
Nov 17, 2020
danieldeleo
reviewed
Nov 17, 2020
danieldeleo
reviewed
Nov 17, 2020
tools/cloud_functions/gcs_event_based_ingest/gcs_ocn_bq_ingest/main.py
Outdated
Show resolved
Hide resolved
danieldeleo
reviewed
Nov 17, 2020
tools/cloud_functions/gcs_event_based_ingest/gcs_ocn_bq_ingest/main.py
Outdated
Show resolved
Hide resolved
danieldeleo
reviewed
Nov 17, 2020
tools/cloud_functions/gcs_event_based_ingest/tests/cli/test_backfill.py
Outdated
Show resolved
Hide resolved
danieldeleo
reviewed
Nov 17, 2020
…/main.py Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
…ckfill.py Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
Co-authored-by: Daniel De Leo <danieldeleo@users.noreply.github.com>
added 4 commits
November 17, 2020 12:29
* use client libraray gsurl parser * explicitly check kind == "storage#object" * fix yapf / isort contention / non-determinism * briefly cache redundant GCS API calls * naming nits
…tils into cloud-functions-ingest
added 3 commits
November 17, 2020 13:21
This way it affects cloudbuild or local invocations
danieldeleo
reviewed
Nov 17, 2020
danieldeleo
approved these changes
Nov 18, 2020
|
CI is happy now ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CLI tool for backfilling notifications or running backfill concurrent invocations to cloud function's main method locally. Improve deafult naming convention regex to support yyyy/mm/dd/hh
TODOs: