Libraries BOM: gRPC and google-auth-library version upgrade #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update dependency com.google.auth:google-auth-library-bom to v0.22.1 update io.grpc.version to v1.34.0
suztomo
changed the title
|
Somehow kokoro-macos does not trigger the build. Posted a note to kokoro-users@. |
elharo
approved these changes
Dec 7, 2020
|
Per @ejona "It may be best to revert this change, or hold off on releasing until you can bump to a 1.34.1. I'm currently investigating grpc/grpc-java#7643, but it appears 1.34.0 has bad credential handling that would impact direct path for some Google properties." I don't think we need to revert but let's not release until this is resolved. |
|
Good information. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update dependency com.google.auth:google-auth-library-bom to v0.22.1
update io.grpc.version to v1.34.0
The build succeeded in my local without showing the error in #1779. Does this work?