Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove test #794

Merged
merged 1 commit into from
May 9, 2024
Merged

chore: remove test #794

merged 1 commit into from
May 9, 2024

Conversation

jackwotherspoon
Copy link
Collaborator

This test is testing some edge case but is flaky.

Removing it.

Fixes #722

@jackwotherspoon jackwotherspoon self-assigned this May 9, 2024
@jackwotherspoon jackwotherspoon marked this pull request as ready for review May 9, 2024 16:01
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner May 9, 2024 16:01
hessjcg
hessjcg approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As a future change: consider if there is a way to isolate the concurrency tests from the actual API tests like we do in Java.

@jackwotherspoon
Copy link
Collaborator Author

LGTM.

As a future change: consider if there is a way to isolate the concurrency tests from the actual API tests like we do in Java.

if you think this is beneficial you can open an issue on the repo. Otherwise this will get forgotten and lost.

@jackwotherspoon jackwotherspoon merged commit e2426db into main May 9, 2024
13 checks passed
@jackwotherspoon jackwotherspoon deleted the jackwotherspoon-patch-2 branch May 9, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

@hessjcg hessjcg hessjcg approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloudsqlconn/internal/cloudsql: TestContextCancelled failed
3 participants
@jackwotherspoon @enocom @hessjcg