Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

feat:support max concurrent workers for Reconciles #333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kinderyj
Copy link
Contributor

@kinderyj kinderyj commented Oct 2, 2020

By default, the concurrent workers for Reconciles is 1, user can change the concurrent works by the function WithOptions when init the builer.Builder ("sigs.k8s.io/controller-runtime"). But Flink-operator hasn't provide user the WithOptions funtion to change the concurrent workers. In this Feature, user can change the concurrent workers when deploy the operator, for example, make deploy MAX_CONCURRENT=2.

Feel free to discuss about this feature, In your prod environment, is concurrent worker=1 enough? Did anyone do some performance test about how many QPS is supported when concurrent worker=1? Thanks~.

@functicons
Copy link
Collaborator

functicons commented Oct 2, 2020

Thanks for the PR! Yep, concurrent worker=1 is sufficient in my use case, and I don't see other users complain about it. Usually we just run a handful of Flink clusters, but each cluster could be very large (1k Pods). I'd like to learn what makes you want to increase the limit and how it makes a difference in your test.

@kinderyj
Copy link
Contributor Author

kinderyj commented Oct 3, 2020

Thanks for the PR! Yep, concurrent worker=1 is sufficient in my use case, and I don't see other users complain about it. Usually we just run a handful of clusters, but each cluster could be very large (1k Pods). I'd like to learn what makes you want to increase the limit and how it makes a difference in your test.

Thanks for your response.
Actually, we also haven't run into the bottleneck. Our flink cluster(job cluster) is small(20 Pods), but many users share one K8s cluster, so the concurrent depends on how many users submit flink cluster at the same time.
We will take a look about the preformace when concurrent worker=1.

@functicons functicons self-requested a review October 4, 2020 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants