Skip to content

Commit

Permalink
chore(fixit): remove redundant region tags
Browse files Browse the repository at this point in the history
Removed these tags:
run_tips_global_lazy
run_tips_global_scope
run_service_to_service_auth
run_secure_request
run_secure_request_do
run_system_package_handler
run_system_package_exec

Manually searched docs and confirmed no references remain.
  • Loading branch information
briandorsey committed May 7, 2024
1 parent 659f01f commit 1bd4c9b
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 14 deletions.
2 changes: 0 additions & 2 deletions functions/tips/lazy.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

// [START functions_tips_lazy_globals]
// [START cloudrun_tips_global_lazy]
// [START run_tips_global_lazy]

// Package tips contains tips for writing Cloud Functions in Go.
package tips
Expand Down Expand Up @@ -54,6 +53,5 @@ func LazyGlobal(w http.ResponseWriter, r *http.Request) {
// Use client.
}

// [END run_tips_global_lazy]
// [END cloudrun_tips_global_lazy]
// [END functions_tips_lazy_globals]
2 changes: 0 additions & 2 deletions functions/tips/scope.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import (

// [START functions_tips_scopes]
// [START cloudrun_tips_global_scope]
// [START run_tips_global_scope]

// h is in the global (instance-wide) scope.
var h string
Expand All @@ -43,7 +42,6 @@ func ScopeDemo(w http.ResponseWriter, r *http.Request) {
fmt.Fprintf(w, "Global: %q, Local: %q", h, l)
}

// [END run_tips_global_scope]
// [END cloudrun_tips_global_scope]
// [END functions_tips_scopes]

Expand Down
2 changes: 0 additions & 2 deletions run/authentication/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
package authentication

// [START cloudrun_service_to_service_auth]
// [START run_service_to_service_auth]
import (
"fmt"
"net/http"
Expand All @@ -42,5 +41,4 @@ func makeGetRequest(serviceURL string) (*http.Response, error) {
return http.DefaultClient.Do(req)
}

// [END run_service_to_service_auth]
// [END cloudrun_service_to_service_auth]
4 changes: 0 additions & 4 deletions run/markdown-preview/editor/render.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
package main

// [START cloudrun_secure_request]
// [START run_secure_request]
import (
"bytes"
"context"
Expand Down Expand Up @@ -65,11 +64,9 @@ func (s *RenderService) NewRequest(method string) (*http.Request, error) {
return req, nil
}

// [END run_secure_request]
// [END cloudrun_secure_request]

// [START cloudrun_secure_request_do]
// [START run_secure_request_do]

var renderClient = &http.Client{Timeout: 30 * time.Second}

Expand Down Expand Up @@ -99,5 +96,4 @@ func (s *RenderService) Render(in []byte) ([]byte, error) {
return out, nil
}

// [END run_secure_request_do]
// [END cloudrun_secure_request_do]
4 changes: 0 additions & 4 deletions run/system_package/graphviz.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ func main() {
}

// [START cloudrun_system_package_handler]
// [START run_system_package_handler]

// diagramHandler renders a diagram using HTTP request parameters and the dot command.
func diagramHandler(w http.ResponseWriter, r *http.Request) {
Expand Down Expand Up @@ -88,11 +87,9 @@ func diagramHandler(w http.ResponseWriter, r *http.Request) {
}
}

// [END run_system_package_handler]
// [END cloudrun_system_package_handler]

// [START cloudrun_system_package_exec]
// [START run_system_package_exec]

// createDiagram generates a diagram image from the provided io.Reader written to the io.Writer.
func createDiagram(w io.Writer, r io.Reader) error {
Expand All @@ -117,5 +114,4 @@ func createDiagram(w io.Writer, r io.Reader) error {
return nil
}

// [END run_system_package_exec]
// [END cloudrun_system_package_exec]

0 comments on commit 1bd4c9b

Please sign in to comment.