Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertexai): system instruction #4121

Merged
merged 7 commits into from May 14, 2024

Conversation

Deleplace
Copy link
Contributor

@Deleplace Deleplace commented May 3, 2024

Go version of the Python sample at https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/generative_ai/gemini_system_instruction.py

Region tag generativeaionvertexai_gemini_system_instruction

Note: using cloud.google.com/go/vertexai v0.7.2-0.20240430000329-84e3236355de as there is no tag yet that includes model.SystemInstruction

Edit: now using cloud.google.com/go/vertexai v0.8.0 — thank you jba

@Deleplace Deleplace requested a review from a team as a code owner May 3, 2024 10:47
Copy link

snippet-bot bot commented May 3, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 3, 2024
@Deleplace Deleplace enabled auto-merge (squash) May 3, 2024 11:40
@Deleplace Deleplace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2024
Copy link
Contributor

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting with pending question on model.GenerateContent.

vertexai/system-instruction/systeminstruction.go Outdated Show resolved Hide resolved
vertexai/system-instruction/systeminstruction.go Outdated Show resolved Hide resolved
vertexai/system-instruction/systeminstruction.go Outdated Show resolved Hide resolved
@Deleplace Deleplace requested a review from grayside May 14, 2024 17:30
@grayside grayside added the api: vertex-ai Issues related to the Vertex AI API. label May 14, 2024
@Deleplace Deleplace merged commit 3c91bb4 into GoogleCloudPlatform:main May 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the Vertex AI API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants